[ioslaves/trash] Handle broken symlinks in deleted subdirectories
ClosedPublic

Authored by davidedmundson on Nov 19 2018, 5:12 PM.

Details

Summary

The trash ioslave currently handles:

  • working symlinks at the toplevel
  • broken symlinks at the toplevel
  • working symlinks in subdirectories

but broken symlinks in a subdirectory get lost.

This is because subdirs are populated from a QDir::listEntries in the
subdirectory folder, which by default filters out broken symlinks.

It's important to list them so that we we restore the directory as
otherwise we lose data. The symlink could become non-dead once files are
restored.

BUG: 400990

Test Plan

Relevant unit test

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 19 2018, 5:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 19 2018, 5:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 19 2018, 5:12 PM
davidedmundson edited the summary of this revision. (Show Details)Nov 19 2018, 5:13 PM
davidedmundson added a reviewer: dfaure.
dfaure accepted this revision.Nov 19 2018, 9:27 PM
This revision is now accepted and ready to land.Nov 19 2018, 9:27 PM
This revision was automatically updated to reflect the committed changes.