Add unittest for document replacement
ClosedPublic
Actions

Authored by bruns on Nov 19 2018, 1:20 AM.

Details

Reviewers

poboiko
ngraham

Group Reviewers

Baloo
Frameworks

Commits

R293:40ef654f7857: Add unittest for document replacement

Summary

Updating a file in place (i.e. when keeping the same inode, e.g. by
appending to it), was not tested previously. Uncovered a bug in the
MTimeDB update.

Depends on: D17000

Test Plan

make && ctest

Diff Detail

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bruns created this revision.Nov 19 2018, 1:20 AM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 19 2018, 1:20 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Nov 19 2018, 1:20 AM

Harbormaster completed remote builds in B5118: Diff 45774.Nov 19 2018, 1:20 AM

bruns added a dependency: D16999: Extend diagnostic output for DB autotests.Nov 19 2018, 1:26 AM

bruns added a dependent revision: D17000: Make sure there is only one MTime per document in the MTimeDB.

bruns removed a dependent revision: D17000: Make sure there is only one MTime per document in the MTimeDB.

bruns added a dependency: D17000: Make sure there is only one MTime per document in the MTimeDB.

ngraham accepted this revision.Nov 19 2018, 2:48 AM

This revision is now accepted and ready to land.Nov 19 2018, 2:48 AM

Closed by commit R293:40ef654f7857: Add unittest for document replacement (authored by bruns). · Explain WhyNov 20 2018, 12:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/writetransactiontest.cpp (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45774	a7f60c6		Nov 19 2018, 1:20 AM	★	★
Diff 2	45858	5b24bd4	R293:40ef654f7857812b114bca8a405a2d1e48bdd18b	Nov 20 2018, 12:00 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f45d7681dec5	ab37b1535d75	a7f60c6e38a1	Stefan Brüns	Add unittest for document replacement (Show More…)	Nov 19 2018, 1:16 AM

Status	Author	Revision
Closed	bruns	D17001 Add unittest for document replacement
Closed	bruns	D17000 Make sure there is only one MTime per document in the MTimeDB
Closed	bruns	D16999 Extend diagnostic output for DB autotests

Diff 45858

View Options

autotests/integration/writetransactiontest.cpp