Do not show "+" for positive numbers if user do not want this
ClosedPublic

Authored by yurchor on Nov 16 2018, 5:36 PM.

Details

Reviewers
broulik
tcanabrava
Group Reviewers
KDE Edu
Summary

BUG: 262690


The new option on the "Diagram" page.


Plot without "+"'s for positive numbers.

Test Plan
  1. Save some plot in the unpatched version.
  2. Patch, compile and start the new version. Open the saved file in it. "+" should be shown for all positive numbers.
  3. Uncheck the item on the "Diagram" page of settings. "+"'s should disappear from the plot.
  4. Save the file. Close the application window. Restart the patched version. Check the "Show "+" for positive numbers" option again. Open the saved file from disk. No "+"'s should be shown in the patched version.
  5. Check the "Show "+" for positive numbers". "+"'s should appear again.
  6. Open the saved file in the old version. No problems should be found, apart from the "+"'s are shown again.

Diff Detail

Repository
R334 KmPlot
Lint
Lint Skipped
Unit
Unit Tests Skipped
yurchor created this revision.Nov 16 2018, 5:36 PM
Restricted Application added projects: KDE Edu, Documentation. · View Herald TranscriptNov 16 2018, 5:36 PM
Restricted Application added subscribers: kde-doc-english, kde-edu. · View Herald Transcript
yurchor requested review of this revision.Nov 16 2018, 5:36 PM
cfeck added a subscriber: cfeck.Nov 16 2018, 5:58 PM
cfeck added inline comments.
doc/index.docbook
586 ↗(On Diff #45602)

should be → is?

yurchor updated this revision to Diff 45603.Nov 16 2018, 6:00 PM
yurchor marked an inline comment as done.

Fix the phrase in docs.

I wouldn't add this. it's just more clutter to the code and to the settings.
mathematically speaking, if a number is not prepended with a sign, it's positive.
I would say to drop the '+' instead of adding a configuration for that.

yurchor updated this revision to Diff 45943.Nov 21 2018, 12:24 PM

Do not show "+" at all.

tcanabrava accepted this revision.Nov 21 2018, 2:27 PM
This revision is now accepted and ready to land.Nov 21 2018, 2:27 PM