Re-add DBus test
ClosedPublic

Authored by davidedmundson on Nov 16 2018, 10:03 AM.

Details

Summary

Ported from KProcess::startDetached to a QProcess we can kill should the
window not exit when closed.

On the KDE CI where the window isn't quitting on close the test might
fail, but it will give us output where we can investigate.

Test Plan

Passes locally

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Konsole. · View Herald TranscriptNov 16 2018, 10:03 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 16 2018, 10:03 AM
hindenburg accepted this revision.Nov 16 2018, 2:58 PM
hindenburg added a subscriber: hindenburg.

Thanks so much for looking into this.

This revision is now accepted and ready to land.Nov 16 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.

CI seems to be frozen again. :(

yea - feel free to commit any changes related to this yourself if you want.

I manage to build the docker kdeorg/ci-suse-qt59 image - and of course the tests pass - so I'm not sure how to help now. I've already disabled this test again to avoid the sysadmins having more work to do.

When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself?

When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself?

I used the script in the comments by knauss in https://phabricator.kde.org/T3689 which I thought is what the CI uses. If there's other instructions, let me know.

Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results.
Did you run "make tests" / "ctest" or did you use the run-tests.py script to execute the unit tests?

Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results.
Did you run "make tests" / "ctest" or did you use the run-tests.py script to execute the unit tests?

The python test script

Okay, that is odd.

I'll try reproducing the issue on the CI nodes in the next day or so - you changed 'kcalcore' in that example to 'konsole' I assume?

Yes, I was actually surprised I managed to get it all to run. Are there official docs on how to setup an ci image and run applications? If not, it would be helpful.

The best we have documentation wise is https://phabricator.kde.org/w/continuous-integration/ however these are quite out of date (and incomplete).