[kcm] Remove profiles code

Authored by romangg on Nov 15 2018, 2:43 PM.



This code seems to be unused for a long time or was never used at all.
Introduced in 2013 there were no substantial commits to it afterwards,
nor is the functionality exposed to the Ui.

Test Plan


Diff Detail

R104 KScreen
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 15 2018, 2:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2018, 2:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Nov 15 2018, 2:43 PM
apol accepted this revision.Nov 16 2018, 12:06 AM
apol added subscribers: dvratil, apol.


I see that @dvratil removed it at some point, maybe he remembers why it's not necessary?

This revision is now accepted and ready to land.Nov 16 2018, 12:06 AM

Profiles were supposed to allow various screen layouts per single setup, for instance, if you have your monitor and TV both connected to your PC, you may want to have "Monitor", "Monitor+TV" and "TV-only" profiles. The idea was to have a combobox in the KCM that would allow you to quickly switch between those profiles without having to fiddle with the rest of the GUI every time. IIRC we did not agree with @afiestas on this feature back then, so it remained disabled (should've been on a branch instead of #ifdefs on master, I admit that ) and while I was still working on kscreen, I never got around to actually finish it and push it.

davidedmundson accepted this revision.Nov 19 2018, 11:03 AM
davidedmundson added a subscriber: davidedmundson.

I remember Alex at the time had a thing that new features should be in master but in #ifdefs so it's easier for other devs to test things than having a giant patchset that no-one can even find and have to keep switching between.

It's not a bad idea, I never run code in branches for a long time.

However, it doesn't work if things get abandoned and die.

This revision was automatically updated to reflect the committed changes.