Differential D16885

Delete the correct item in removeDesktop
ClosedPublic
Actions

Authored by davidedmundson on Nov 14 2018, 11:55 PM.

Details

Reviewers
broulik
Group Reviewers
KWin
Commits
R127:f25eadc92c47: Delete the correct item in removeDesktop
Summary

QList::erase will move the data underneath where the iterator is
pointing, we want to delete the entry we're about to remove from the
list.

Test Plan

Relevant tests now behave better

Diff Detail

Repository
R127 KWayland
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4947
Build 4965: arc lint + arc unit
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 14 2018, 11:55 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 14 2018, 11:55 PM
broulik accepted this revision.Nov 14 2018, 11:57 PM
This revision is now accepted and ready to land.Nov 14 2018, 11:57 PM
Closed by commit R127:f25eadc92c47: Delete the correct item in removeDesktop (authored by davidedmundson). · Explain WhyNov 15 2018, 10:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45488

View Options

src/server/plasmavirtualdesktop_interface.cpp

Loading...