Differential D16875

[kded] Cleanup KScreenDaemon class
ClosedPublic
Actions

Authored by romangg on Nov 14 2018, 10:14 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R104:4a177884b052: [kded] Cleanup KScreenDaemon class
Summary

Do not export class, privatize and unvirtualize members. Rename
config init function, cleanup includes and white space.

Test Plan

Manually in Wayland session.

Diff Detail

Repository
R104 KScreen
Branch
codeCleanupExport
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4927
Build 4945: arc lint + arc unit
romangg created this revision.Nov 14 2018, 10:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2018, 10:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Nov 14 2018, 10:14 AM
davidedmundson requested changes to this revision.Nov 14 2018, 11:36 AM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
kded/daemon.h
47

this has moved from being a slot.

If it is invoked from DBus as the comment suggests that will be a problem

This revision now requires changes to proceed.Nov 14 2018, 11:36 AM
romangg added inline comments.Nov 14 2018, 4:42 PM
kded/daemon.h
47

Are you sure this is a problem? I just tested it manually with qdbusviewer and the method was called accordingly.

Nowadays in Qt can't every function act as a slot, even without the Q_SLOTS specifier?

broulik added a subscriber: broulik.Nov 14 2018, 5:34 PM
broulik added inline comments.
kded/daemon.h
47

For function ptr connect, yes, for runtime introspection, no

davidedmundson added inline comments.Nov 14 2018, 5:39 PM
kded/daemon.h
47

If it's done with QDBusConnection::registerObject(this) then it definitely needs runtime introspection.

If it's done with an adaptor pattern, then maybe not.

romangg updated this revision to Diff 45466.Nov 14 2018, 5:52 PM
  • Add back Q_SLOTS specifier to be sure
romangg marked 4 inline comments as done.Nov 14 2018, 5:52 PM
davidedmundson accepted this revision.Nov 14 2018, 5:53 PM
This revision is now accepted and ready to land.Nov 14 2018, 5:53 PM
Closed by commit R104:4a177884b052: [kded] Cleanup KScreenDaemon class (authored by romangg). · Explain WhyNov 14 2018, 6:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/daemon.h (102 lines)
Mkded/daemon.cpp (29 lines)

Diff 45448

View Options

kded/daemon.h

Loading...
View Options

kded/daemon.cpp

Loading...