touchscreen text controls
ClosedPublic

Authored by mart on Nov 13 2018, 11:20 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R858:01411790d480: touchscreen text controls
Summary

on QQC2 the controls to be able to select, cut,copy and paste text are
responsibility of the style.
this enables onscreen text manipulation when the system is in tabletMode
state, just as D16841 for Plasma style

Test Plan

they work when kirigami is in tablet mode, they are completely invisible when not
and the system behaves completely desktop-like

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Nov 13 2018, 11:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 13 2018, 11:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 13 2018, 11:20 AM
broulik added inline comments.
org.kde.desktop/private/MobileTextActionsToolBar.qml
25 ↗(On Diff #45408)

Can you check whether this macro substitution actually works for the "private" folder?

mart added inline comments.Nov 13 2018, 11:39 AM
org.kde.desktop/private/MobileTextActionsToolBar.qml
25 ↗(On Diff #45408)

yes it works correctly, the problem in the plasma version was the separate install of the style as an import

apol added a subscriber: apol.Nov 22 2018, 1:40 PM

isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger?

mart added a comment.Nov 22 2018, 5:33 PM
In D16860#364161, @apol wrote:

isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger?

i don't think we can know that from QML, would need access to events of the textedit, which would need a c++ based eventfilter (not sure i want to go there?)
I would use the way we are using for everything which is this central tabletmode config point.

apol accepted this revision.Nov 22 2018, 6:02 PM

LGTM

This revision is now accepted and ready to land.Nov 22 2018, 6:02 PM
mart added a comment.Nov 23 2018, 9:20 AM

for the future, could maybe be a global eventfilter of the window which does the switch of mode when a touch event arrived or when a mouse event arrived...will have to be tought trough...

This revision was automatically updated to reflect the committed changes.
Abroas added a subscriber: Abroas.Jan 4 2021, 5:56 PM