Don't cache value of popupWindow property in EffectWindow
ClosedPublic

Authored by zzag on Nov 12 2018, 10:07 AM.

Details

Summary

With the plasma shell protocol, a ShellClient gets its role/window type
after it's created, so the cached value of the popupWindow property in
EffectWindow can be wrong.

In addition to that, the value of the popupWindow property still can be
wrong because plasma shell surfaces don't have xdg-popup role, so we need
to check NetWM-based window type in ShellClient::isPopupWindow.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Nov 12 2018, 10:07 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 12 2018, 10:07 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Nov 12 2018, 10:07 AM
davidedmundson accepted this revision.Nov 12 2018, 10:10 AM
davidedmundson added a subscriber: davidedmundson.

FWIW, long term I want to change plasma popups to use XDGPopups as a base.

This revision is now accepted and ready to land.Nov 12 2018, 10:10 AM
zzag added a comment.Nov 12 2018, 10:10 AM

FWIW, long term I want to change plasma popups to use XDGPopups as a base.

Sweet!

This revision was automatically updated to reflect the committed changes.