Differential D16781

Bump KmPlot version
ClosedPublic
Actions

Authored by yurchor on Nov 9 2018, 5:29 PM.

Details

Reviewers
cfeck
Group Reviewers
KDE Edu
Commits
R334:e6d1c4358f71: Bump KmPlot version
Summary

Thanks to the help of KDE Edutainment reviewers and community it became possible to port KmPlot away from the deprecated dependencies and fix several nasty bugs.

The fixed bug list (with several showstoppers):

https://bugs.kde.org/show_bug.cgi?id=190860
https://bugs.kde.org/show_bug.cgi?id=210136
https://bugs.kde.org/show_bug.cgi?id=302691
https://bugs.kde.org/show_bug.cgi?id=325627
https://bugs.kde.org/show_bug.cgi?id=360685
https://bugs.kde.org/show_bug.cgi?id=385715

and maybe
https://bugs.kde.org/show_bug.cgi?id=267203
https://bugs.kde.org/show_bug.cgi?id=320394

Hopefully, not many new bugs were added.

Is it possible to bump version from "1.2.1" to "1.2.2"?

Test Plan

Compile, run, Help -> About KmPlot.

Diff Detail

Repository
R334 KmPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Nov 9 2018, 5:29 PM
Restricted Application added projects: KDE Edu, Documentation. · View Herald TranscriptNov 9 2018, 5:29 PM
Restricted Application added subscribers: kde-doc-english, kde-edu. · View Herald Transcript
yurchor requested review of this revision.Nov 9 2018, 5:29 PM
cfeck added a subscriber: cfeck.Nov 9 2018, 8:59 PM

Why not 1.3? That's a lot you fixed, thanks for that :)

yurchor added a comment.Nov 9 2018, 9:05 PM
In D16781#357049, @cfeck wrote:

Why not 1.3? That's a lot you fixed, thanks for that :)

Absolutely no new features. Just a bug fixing release.

cfeck accepted this revision.Nov 9 2018, 9:18 PM

New Feature: Qt 5 port! :)

I just checked, the bump to 1.2.1 happened 10 years ago. With the complete Qt 5 port, we shouldn't be shy about bumping to 1.3.0, even if there are no new features. I know developers who would call it 2.0.0 just because it was ported.

But I will let you decide, any greater than 1.2.1 is fine :)

This revision is now accepted and ready to land.Nov 9 2018, 9:18 PM
aacid added a subscriber: aacid.Nov 9 2018, 9:33 PM

When you merge this, please make sure to also merge it to the newly created 18.12 branch

Closed by commit R334:e6d1c4358f71: Bump KmPlot version (authored by yurchor). · Explain WhyNov 9 2018, 9:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdoc/index.docbook (4 lines)
Mkmplot/main.cpp (2 lines)

Diff 45207

View Options

doc/index.docbook

Loading...
View Options

kmplot/main.cpp

Loading...