Differential D16753

[aurorae] Print qml errors during instantiation of qml based deco
ClosedPublic
Actions

Authored by graesslin on Nov 8 2018, 8:25 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:80d0915cf8e9: [aurorae] Print qml errors during instantiation of qml based deco
Summary

So far we didn't know why plastik wasn't loaded. Now we get the error
messages.

Test Plan

Saw error messages while investigating failing KWin test

Diff Detail

Repository
R108 KWin
Branch
aurorae-qml-errors
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4707
Build 4725: arc lint + arc unit
graesslin created this revision.Nov 8 2018, 8:25 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 8 2018, 8:25 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 8 2018, 8:25 AM
zzag added a subscriber: zzag.Nov 8 2018, 8:53 AM
zzag added inline comments.
plugins/kdecorations/aurorae/src/aurorae.cpp
321

Do we need to call toString? https://code.woboq.org/qt5/qtdeclarative/src/qml/qml/qqmlerror.h.html#_Zls6QDebugRK9QQmlError

graesslin updated this revision to Diff 45103.Nov 8 2018, 9:03 AM

No toError

zzag accepted this revision.Nov 8 2018, 9:04 AM
This revision is now accepted and ready to land.Nov 8 2018, 9:04 AM
Closed by commit R108:80d0915cf8e9: [aurorae] Print qml errors during instantiation of qml based deco (authored by graesslin). · Explain WhyNov 8 2018, 9:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45098

View Options

plugins/kdecorations/aurorae/src/aurorae.cpp

Loading...