kdev-embedded review
AbandonedPublic

Authored by kfunk on May 24 2016, 4:15 PM.

Diff Detail

Repository
R185 KDevelop Plugin: Embedded Platforms
Lint
Lint Skipped
Unit
Unit Tests Skipped
patrickelectric retitled this revision from to kdev-embedded review.
patrickelectric updated this object.
patrickelectric edited the test plan for this revision. (Show Details)
patrickelectric added reviewers: brauch, tcanabrava.
patrickelectric set the repository for this revision to R185 KDevelop Plugin: Embedded Platforms.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 24 2016, 4:15 PM
arduinowindow.cpp
368

<kfunk> : small note: use KColorScheme in ArduinoWindow::getRedRichTextSelected, instead of a hard-coded 'red'
e.g. KColorScheme(KColorScheme::View, KColorScheme::NegativeText)
or sth else as 2nd param -- I don't think it's supposed to be 'negative'

arduinowindow.h
11

lost comment

toolkit.cpp
35

lost code

brauch added inline comments.May 24 2016, 4:39 PM
arduinowindow.cpp
72

I'd just put this on the stack

110

i18n

113

No fixed colors, sorry. Use the palette. ;)

115

i18n

135

const auto path = ...

136

that title is not super great :D

275

Just a note that this is the point where you break e.g. Windows compatiblity. Maybe you find a way to make this also work on windows, at least potentially?

284

i18n()

286

missing space after comma

295

i18n

300

i18n

319

always use braces please ... also auto enable = state == Qt::Checked would be simpler imo ;)

343

i18n

368

No fixed colors. Use the palette.

arduinowindow.h
11

don't worry, you can occasionally include something :D

board.cpp
93

I don't really like this lastIndexOf(0), where is it written that the frequency ends with a 0? it could reasonably be 3999999 or something like that.

153

remove ( )

toolkit.cpp
34

remove

firsttimewizard.h
8

this file is a configuration output from firsttimewizard.h.in, must be removed

patrickelectric marked 11 inline comments as done.EditedMay 26 2016, 9:53 PM

Some corrections done

arduinowindow.cpp
113

can I use Qt::color, e.g: Qt::red ?

arduinowindow.cpp
113

Ok, I get now.
I will use palette.

patrickelectric marked 6 inline comments as done.May 28 2016, 2:50 AM
patrickelectric added inline comments.
arduinowindow.cpp
72

did not quite understand

275

I will try to talk with someone to help me with Solid or use QSerial for while.

brauch added inline comments.May 28 2016, 1:55 PM
arduinowindow.cpp
72

don't use new or a pointer, just have a "QProcess m_process" member

kfunk commandeered this revision.Mar 7 2017, 4:45 PM
kfunk abandoned this revision.
kfunk added a reviewer: patrickelectric.

This review went stale. Everything is pushed by now.