Details
- Reviewers
tcanabrava brauch patrickelectric
Diff Detail
- Repository
- R185 KDevelop Plugin: Embedded Platforms
- Lint
Lint Skipped - Unit
Unit Tests Skipped
arduinowindow.cpp | ||
---|---|---|
368 | <kfunk> : small note: use KColorScheme in ArduinoWindow::getRedRichTextSelected, instead of a hard-coded 'red' | |
arduinowindow.h | ||
11 | lost comment |
toolkit.cpp | ||
---|---|---|
35 | lost code |
arduinowindow.cpp | ||
---|---|---|
72 | I'd just put this on the stack | |
110 | i18n | |
113 | No fixed colors, sorry. Use the palette. ;) | |
115 | i18n | |
135 | const auto path = ... | |
136 | that title is not super great :D | |
275 | Just a note that this is the point where you break e.g. Windows compatiblity. Maybe you find a way to make this also work on windows, at least potentially? | |
284 | i18n() | |
286 | missing space after comma | |
295 | i18n | |
300 | i18n | |
319 | always use braces please ... also auto enable = state == Qt::Checked would be simpler imo ;) | |
343 | i18n | |
368 | No fixed colors. Use the palette. | |
arduinowindow.h | ||
11 | don't worry, you can occasionally include something :D | |
board.cpp | ||
93 | I don't really like this lastIndexOf(0), where is it written that the frequency ends with a 0? it could reasonably be 3999999 or something like that. | |
153 | remove ( ) | |
toolkit.cpp | ||
34 | remove |
firsttimewizard.h | ||
---|---|---|
8 | this file is a configuration output from firsttimewizard.h.in, must be removed |
arduinowindow.cpp | ||
---|---|---|
113 | can I use Qt::color, e.g: Qt::red ? |
arduinowindow.cpp | ||
---|---|---|
113 | Ok, I get now. |
arduinowindow.cpp | ||
---|---|---|
72 | don't use new or a pointer, just have a "QProcess m_process" member |