[server] Text input content hint and purpose per protocol version
ClosedPublic
Actions

Authored by romangg on Nov 6 2018, 1:41 PM.

Details

Reviewers

Group Reviewers

KWin
Frameworks

Commits

Summary

Convert content hint and purpose according to used text-input protocol version.

This way we can use different specifiers, which enables us in the future to use
the default hint of v0 and the pin purpose of v3.

Also code is cleaner when using the correctly versioned specifier names according
to the protocol version.

Test Plan

Compiles, autotest passes.

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

romangg requested review of this revision.Nov 6 2018, 1:41 PM

zzag added inline comments.

src/server/textinput_interface.cpp
66	purpose_? or just keep previous name (wlPurpose)? https://techbase.kde.org/Policies/Frameworks_Coding_Style#Variable_Declarations

src/server/textinput_interface.cpp
66	wlPurpose is also an abbreviation. ;) And in the header file it is named `purpose`. Makes more sense to me to have the name without abbreviation in the API. I'll rename the function variable though.

zzag accepted this revision.Nov 6 2018, 4:05 PM

zzag added inline comments.

src/server/textinput_interface.cpp
66	wlPurpose is also an abbreviation. ;) You caught me. :D
src/server/textinput_interface_p.h
69	Can be const.

This revision is now accepted and ready to land.Nov 6 2018, 4:05 PM

romangg marked an inline comment as done.Nov 7 2018, 1:40 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/server/textinput_interface.cpp (87 lines)
M			src/server/textinput_interface_p.h (3 lines)
M			src/server/textinput_interface_v0.cpp (77 lines)
M			src/server/textinput_interface_v2.cpp (85 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44966	12e46aa		Nov 6 2018, 1:41 PM	★	★
Diff 2	44970	12e46aa	- Rename variables, function	Nov 6 2018, 2:45 PM	★	★
Diff 3	45033	12e46aa	R127:7c0f6cfa2eaed5312b0f86184bd8a48a3e75050c	Nov 7 2018, 1:40 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f5ca6ea32c90	ca99fcc75190	c73044871fdc	Roman Gilg	Rename variables, function	Nov 6 2018, 2:44 PM
c73044871fdc	10d223349beb	12e46aa19296	Roman Gilg	[server] Text input content hint and purpose per protocol version (Show More…)	Nov 6 2018, 1:33 PM

	Status	Author	Revision
	Abandoned	romangg	D16709 [server] Support text input v0 default content hint
	Closed	romangg	D16708 [server] Text input content hint and purpose per protocol version