BUG: 367696
The dark theme along with the dark icon was hindering the visibility of the konsole icon. So in order to make it a bit more visible, I have added a lighter colored border around the icon
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- utilities-terminal (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5878 Build 5896: arc lint + arc unit
Comment Actions
Thanks for the patch! And thanks for using arc, too. That makes life a bit easier for us. :)
Couple of things:
- The title becomes the commit message, so please change it to something more descriptive, such as, "Improve visibility for Konsole icon when using Breeze Dark"
- Please add BUG: 367696 to its own line in the summary section and add some explanation there regarding why this patch is necessary.
- The Test Plan section is empty; we need some evidence of testing. Can you provide some screenshots that show the icon when using Breeze Dark?
- In the future, please tag VDG for anything that involve an icon or visual change.
See also https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
Comment Actions
Thanks for making those changes. Now we can see the icon, and also an issue that needs to be corrected. :) Notice how the corners look really bright--especially the bottom corners? That's a problem. I suspect what's happening is that the lines you drew to make the border are semi-transparent, but overlap one another at the corners, so the corners are mor opaque and therefore lighter. Either way, that "dots in the corner" effect must be fixed before this can land.
Comment Actions
Great, the corners are now correct!
For the outline let's try to use one of the Breeze colors, which you can see here: https://hig.kde.org/style/color/default.html
What we typically do is choose one of the shades of gray, and make it partially transparent. That way it's not too bold and stark, but it still accomplishes the goal of separating the icon from what it's drawn on top of.
@ndavis, do we have a consistent style for these translucent outlines? Should we come up with one?
Comment Actions
Why are we using a color icon at such a small size? Wouldn't it make more sense to make a monochrome icon at that size?
This change would also affect how the Konsole icon looks in other places such as the task manager. At 100% size, I don't see this looking good on the task manager.
Comment Actions
Agree with @ndavis with respect to the icon. I would be in favor of using something similar (if not identical) to dialog-scripts. It's monochrome and works with dark and light backgrounds.
Comment Actions
We had a big discussion in the VDG room and concluded that Konsole shouldn't even use this icon for its tabs by default (https://bugs.kde.org/show_bug.cgi?id=401864), which partially solves the problem.
However I personally think it's still worthwhile to tweak this icon in the manner suggested here, as long as we turn down the outline intensity a bunch.
Comment Actions
@anishgiri What is the advantage of using this outlined version of the Konsole icon(which we haven't seen in a light scheme yet) compared to using one of the monochrome icons already available?
Comment Actions
App icons shouldn't have monochrome versions except for very limited exceptions like on the system tray. The issue being solved here is a general problem that we have when a dark icon is used with a dark color scheme. It's by no means limited to this icon (see also D17469), but we have some visual restrictions on resolving it since this is an app icon and we can't really redesign the icon like we can in D17469.
Comment Actions
This doesn't seem to actually work; after applying the patch; the new icon is not actually used with dark themes nor visible in Cuttlefish. Also the dupe test is now failing:
The following tests FAILED:
4 - dupe (Failed)
Errors while running CTestPlease make sure to run the unit tests with ctest.