Add "event" field to ConversationMessage
Update packet type with proper field names and commenting
Future "proof" SmsPlugin against new event types
Details
Details
- Reviewers
apol - Group Reviewers
KDE Connect - Commits
- R224:c1e36895b56e: [Desktop] Make message syncronization interface capable of handling future…
- Install the corresponding Android-side patch D16600
- Verify that it is possible to synchronize messages the same as it was before
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- messaging-future-view
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4870 Build 4888: arc lint + arc unit
| interfaces/conversationmessage.h | ||
|---|---|---|
| 95 | How about isTextMessage? | |
| interfaces/conversationmessage.h | ||
|---|---|---|
| 95 | The reason for not "isTextMessage" is because you could have a picture message which also contains text, so saying "isTextMessage" would technically be not true. The message I am trying to get across with "containsPureText" is that the message contains something which can be directly displayed, as opposed to HTML or some other weirdness. I could change it to something like "containsTextBody" or something if you like that better | |
Comment Actions
Other than that, let's get this in.
| interfaces/conversationmessage.h | ||
|---|---|---|
| 95 | I like containsTextBody more, yes. | |
Comment Actions
I will need to upload the Android-side patch too, since without that change this plugin will break. Could you accept that one too? :)
Comment Actions
I know it sucks reading this, but I don't feel qualified to accept a patch in android.