Differential D16600

[Android] Make message syncronization interface capable of handling future changes
ClosedPublic
Actions

Authored by sredman on Nov 1 2018, 8:31 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:da629f9756ac: [Android] Make message syncronization interface capable of handling future…
Summary

Update packet type with proper field names and commenting

Send new "event" field

Test Plan
  • Install corresponding Desktop-side patch D16599
  • Verify that it is still possible to synchronize messages the same as it was before

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
messaging-future-view
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4461
Build 4479: arc lint + arc unit
sredman created this revision.Nov 1 2018, 8:31 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 1 2018, 8:31 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Nov 1 2018, 8:31 PM
sredman updated this revision to Diff 44677.Nov 1 2018, 10:31 PM
  • Remove "read" field
sredman updated this revision to Diff 44678.Nov 1 2018, 10:34 PM

My brain is fried. Too much math homework today.

  • Revert "Remove "read" field"
nicolasfella accepted this revision.Nov 14 2018, 11:53 PM
nicolasfella added a subscriber: nicolasfella.

I didn't actually test, but look ok

This revision is now accepted and ready to land.Nov 14 2018, 11:53 PM
sredman closed this revision.Nov 15 2018, 11:56 PM

Revision Contents
Changeset List

Diff 44678

View Options

src/org/kde/kdeconnect/Helpers/SMSHelper.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SMSPlugin/SMSPlugin.java

Loading...