Differential D16563

Actually use fileNameTerms and xAttrTerms
ClosedPublic
Actions

Authored by aacid on Oct 31 2018, 9:51 PM.

Details

Reviewers
bruns
Group Reviewers
Baloo
Commits
R293:dbe4c447c6ff: Actually use fileNameTerms and xAttrTerms

Diff Detail

Repository
R293 Baloo
Branch
arcpatch-D16563
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4422
Build 4440: arc lint + arc unit
aacid created this revision.Oct 31 2018, 9:51 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 31 2018, 9:51 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Oct 31 2018, 9:51 PM
bruns requested changes to this revision.Oct 31 2018, 11:22 PM
bruns added inline comments.
src/engine/transaction.cpp
519

should be fileNameTerms here

525

likewise

This revision now requires changes to proceed.Oct 31 2018, 11:22 PM
aacid updated this revision to Diff 44617.Nov 1 2018, 10:46 AM

actually use the variables

aacid updated this revision to Diff 44618.Nov 1 2018, 10:47 AM
aacid retitled this revision from Remove unused variables to Actually use fileNameTerms and xAttrTerms.

update summary

aacid edited the summary of this revision. (Show Details)Nov 1 2018, 10:47 AM
bruns accepted this revision.Nov 1 2018, 1:22 PM
This revision is now accepted and ready to land.Nov 1 2018, 1:22 PM
aacid closed this revision.Nov 1 2018, 4:13 PM

Revision Contents
Changeset List

PathPackages
Msrc/engine/transaction.cpp (4 lines)

Diff 44618

View Options

src/engine/transaction.cpp

Loading...