Differential D16529

make libssh module default to the "new" libssh config by default
ClosedPublic
Actions

Authored by sitter on Oct 30 2018, 3:45 PM.

Details

Reviewers
broulik
asn
Commits
R320:0e129b10ae30: make libssh module default to the "new" libssh config by default
Summary
  • rename module from LibSSH to libssh so casing is consistent with config
  • module now quietly attempts to find libssh by config and returns if found
  • if it was not found we'll fall back to manual lookup
  • adjust actual FOUND variable use for correct case
  • fix package case in properties set up (this is case sensitive)

this is singularly necessary because the config file is not correctly
packaged in ubuntu 18.04 (LTS)

https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1800135/comments/2

This reverts 3b1fd6bd8866da2dadd33705af53613236503efc.

BUG: 400291

Test Plan

builds in ubuntu docker container and with a system that has a proper config

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Oct 30 2018, 3:45 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptOct 30 2018, 3:45 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Oct 30 2018, 3:45 PM
broulik accepted this revision.Oct 30 2018, 5:48 PM
This revision is now accepted and ready to land.Oct 30 2018, 5:48 PM
Closed by commit R320:0e129b10ae30: make libssh module default to the "new" libssh config by default (authored by sitter). · Explain WhyOct 31 2018, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
AMcmake/Findlibssh.cmake (113 lines)

Diff 44531

View Options

CMakeLists.txt

Loading...
View Options

cmake/Findlibssh.cmake

Loading...