Simplify pairing from notification
ClosedPublic

Authored by eduisters on Oct 29 2018, 7:00 PM.

Details

Summary

When a pairing is accepted or rejected through notification actions a new DeviceFragment was created but this fragment was never actually attached to the fragment manager so not displayed to the user.

Test Plan

Request a pairing from the desktop and Accept or Reject the pairing on Android using the notification Action buttons

When you accept the pairing the DeviceFragment should be shown for the device, the action bar title should be set to the devices name and the device should be selected in the NavigationView

When you reject the pairing the PairingFragment should be shown

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Oct 29 2018, 7:00 PM
Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptOct 29 2018, 7:00 PM
eduisters requested review of this revision.Oct 29 2018, 7:00 PM

Is there any visible behavior change?

Is there any visible behavior change?

No, there are no visible behavior changes. Also see my inline comments

src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
378

This is the only line that actually does anything in this method

405

The above 2 lines are the ones that actually do something in the method

This revision is now accepted and ready to land.Oct 30 2018, 11:41 AM
This revision was automatically updated to reflect the committed changes.