Fix for histogram type switching
ClosedPublic

Authored by • ghost91 on May 21 2016, 1:22 AM.

Details

Reviewers
rempt
Group Reviewers
Krita: 3.0 bugs sprint
Krita
Summary

Currently in histogram (accessed by Layers->Histogram... ) radio button Linear/Logarithmic have no effect. Signal about the change is not propagated to the function that handles mode switch.

Change connects radio button signal directly to the handler function. In addition, I removed the complicated logic of following the switch and replaced it with directly reading the radio button state.

Test Plan
  1. Open a reasonable image.
  2. In menu select Layers->Histogram.
  3. Toggle radio buttons Linear/Logarithmic.
  4. Observe that histogram changes.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
• ghost91 updated this revision to Diff 3914.May 21 2016, 1:22 AM
• ghost91 retitled this revision from to Fix for histogram type switching.
• ghost91 updated this object.
• ghost91 edited the test plan for this revision. (Show Details)
• ghost91 set the repository for this revision to R37 Krita.
Restricted Application added a subscriber: woltherav. · View Herald TranscriptMay 21 2016, 1:22 AM
rempt accepted this revision.May 21 2016, 7:10 AM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Thanks! I've tried the patch and it works. Do you have commit access or should I commit for you?

This revision is now accepted and ready to land.May 21 2016, 7:10 AM

My first patch, so I don't have commit access. Please commit it for me.
Thank you. Eugene

dkazakov closed this revision.Aug 17 2016, 7:06 AM