kcms/kfontinst/apps/Printer.cpp
349	Pass this as the last argument, so it has a parent and doesn't leak. On this one and the rest of `new QDialogButtonBox`.
350	Use new syntax. `&QDialog::rejected` and `&CPrinter::slotCancelClicked`
kcms/kfontinst/kcmfontinst/DuplicatesDialog.cpp
76	use new syntax as well.

kcms/kfontinst/apps/Printer.cpp
349	There is no need to set a parent in the constructor. QLayout::addWidget() will do it later.

kcms/kfontinst/apps/Printer.cpp
349	From the Qt documentation ( https://doc.qt.io/qt-5/layout.html ): "When you use a layout, you do not need to pass a parent when constructing the child widgets. The layout will automatically reparent the widgets (using QWidget::setParent()) so that they are children of the widget on which the layout is installed."

Use the new signal and slot syntax for QDialogButtonBox objects.

volkov marked 2 inline comments as done.May 20 2016, 2:51 PM

mart added a reviewer: mart.

mart added a subscriber: mart.

mart added inline comments.

kcms/kfontinst/apps/Printer.cpp
349	yep, that's correct, or alternatively to make it clearer, it works also the form QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Cancel, layout); that would add the widget to the layout and reparent it at the same time right upon creation

This revision is now accepted and ready to land.May 23 2016, 8:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcms/kfontinst/apps/Printer.h (6 lines)
M			kcms/kfontinst/apps/Printer.cpp (25 lines)
M			kcms/kfontinst/kcmfontinst/DuplicatesDialog.h (10 lines)
M			kcms/kfontinst/kcmfontinst/DuplicatesDialog.cpp (52 lines)
M			kcms/kfontinst/kcmfontinst/JobRunner.h (11 lines)
M			kcms/kfontinst/kcmfontinst/JobRunner.cpp (112 lines)
M			kcms/kfontinst/kcmfontinst/KCmFontInst.cpp (9 lines)
M			kcms/kfontinst/kcmfontinst/PrintDialog.h (4 lines)
M			kcms/kfontinst/kcmfontinst/PrintDialog.cpp (26 lines)
M			kcms/kfontinst/viewpart/FontViewPart.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3906			May 20 2016, 1:06 PM	★	★
Diff 2	3908			May 20 2016, 2:44 PM	★	★
Diff 3	4030	ea9b197	rPLASMADESKTOP20bbf2366ae5b15df8e5197f08049b42f42565e7	May 27 2016, 9:56 AM	★	★

Status	Author	Revision
Closed	volkov	D1676 kfontinst: Port to QApplication and QCommandLineParser
Closed	volkov	D1675 kfontinst: Port to QTemporaryDir
Closed	volkov	D1657 kfontinst: Port away from KStandardDirs
Closed	volkov	D1647 kfontinst: Port to QDialog