Differential D1676

kfontinst: Port to QApplication and QCommandLineParser
ClosedPublic
Actions

Authored by volkov on May 24 2016, 4:50 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R119:7cb098ec90e1: kfontinst: Port to QApplication and QCommandLineParser

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volkov updated this revision to Diff 3971.May 24 2016, 4:50 PM
volkov retitled this revision from to kfontinst: Port to QApplication and QCommandLineParser.
volkov updated this object.
volkov edited the test plan for this revision. (Show Details)
volkov added a reviewer: Plasma.
volkov set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 24 2016, 4:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.May 24 2016, 6:16 PM

LGTM +1

kcms/kfontinst/apps/Viewer.cpp
131

Prefer foreach to iterate a QList

volkov updated this revision to Diff 3996.May 25 2016, 12:31 PM
volkov marked an inline comment as done.
apol accepted this revision.May 25 2016, 12:36 PM
apol added a reviewer: apol.
This revision is now accepted and ready to land.May 25 2016, 12:36 PM
Closed by commit R119:7cb098ec90e1: kfontinst: Port to QApplication and QCommandLineParser (authored by volkov). · Explain WhyMay 30 2016, 5:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4046

View Options

kcms/kfontinst/apps/CMakeLists.txt

Loading...
View Options

kcms/kfontinst/apps/Installer.cpp

Loading...
View Options

kcms/kfontinst/apps/Printer.cpp

Loading...
View Options

kcms/kfontinst/apps/Viewer.cpp

Loading...
View Options

kcms/kfontinst/apps/installfont.desktop

Loading...
View Options

kcms/kfontinst/viewpart/CharTip.cpp

Loading...