[effects/scale] Port to JavaScript
ClosedPublic

Authored by zzag on Oct 28 2018, 11:33 AM.

Details

Summary

Now, when the scripting effects API has all required ingredients to port
the Scale effect to JavaScript we finally can do it.

The main rationale for porting this effect to JavaScript is that
scripted effects API lets us focus more on what we want instead of
"how".

Visually, the ported version doesn't deviate from the C++ version.

Test Plan
  • Enable the Scale effect;
  • Open/close a window.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Oct 28 2018, 11:33 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 28 2018, 11:33 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 28 2018, 11:33 AM

Also, I hope that this effect will serve as a boilerplate/example for future window open/close animations on store.kde.org.

graesslin accepted this revision.Oct 29 2018, 4:56 AM
graesslin added a subscriber: graesslin.

The main rationale for porting this effect to JavaScript is that

scripted effects API lets us focus more on what we want instead of
"how".

Reading this makes me happy as that was one of the ideas when developing the effect scripting API.

This revision is now accepted and ready to land.Oct 29 2018, 4:56 AM
This revision was automatically updated to reflect the committed changes.