[effects] Improve the Scale In effect
AbandonedPublic

Authored by zzag on May 27 2018, 4:19 PM.

Details

Reviewers
ngraham
Group Reviewers
KWin
Plasma
VDG
Summary
  • Make the animation more subtle
  • Do not animate the shutdown screen
  • Avoid conflicts with the Fade effect
  • Simplify CFG

Depends on D13153

Test Plan
  • Enable the Scale In effect
  • Open a new window

Diff Detail

Repository
R108 KWin
Lint
No Linters Available
Unit
No Unit Test Coverage
zzag created this revision.May 27 2018, 4:19 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 27 2018, 4:19 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 27 2018, 4:19 PM
zzag planned changes to this revision.May 27 2018, 4:23 PM
zzag edited the summary of this revision. (Show Details)
zzag added a dependent revision: D13155: [effects] Add Scale Out effect.
zzag updated this revision to Diff 35024.May 28 2018, 1:19 PM

Rebase.

zzag planned changes to this revision.May 28 2018, 1:21 PM
zzag edited the summary of this revision. (Show Details)
abetts added a subscriber: abetts.May 28 2018, 3:40 PM

Can you also show an example of what this would do to the shutdown screen? Before and after please?

zzag added a comment.May 28 2018, 4:42 PM

Can you also show an example of what this would do to the shutdown screen? Before and after please?

Before

_Current the Scale In effect. (I increased its duration up to 5 seconds so the animation is more noticable on the video)_

FWIW, the Fade effect, the Logout effect, and the Scale In effect conflict with each other.

After

zzag added a comment.May 28 2018, 4:54 PM

@abetts Could you also please take a look at D13155?

Love it! Is the effect going to be that slow?

zzag added a comment.May 28 2018, 5:29 PM

Love it! Is the effect going to be that slow?

No, it will be faster. On the videos, I set animation duration to 5s(default is 160 ms) to see clearly what effects are doing.

I'm afraid that increasing animation duration changes overall feel of the scale animations. Recording these effects with the default animation duration(160ms) is a little bit challenging for me. It would be great if you could test them by yourself and give me some hints on how to improve them.

zzag added a subscriber: ngraham.May 28 2018, 5:31 PM
In D13154#269748, @zzag wrote:

Love it! Is the effect going to be that slow?

No, it will be faster. On the videos, I set animation duration to 5s(default is 160 ms) to see clearly what effects are doing.

I'm afraid that increasing animation duration changes overall feel of the scale animations. Recording these effects with the default animation duration(160ms) is a little bit challenging for me. It would be great if you could test them by yourself and give me some hints on how to improve them.

Thanks, just wanted to be sure.

zzag updated this revision to Diff 35056.May 28 2018, 8:28 PM

Make it slightly more subtle.

zzag retitled this revision from WIP: [effects] Improve the Scale In effect to [effects] Improve the Scale In effect.May 28 2018, 8:30 PM
zzag edited the summary of this revision. (Show Details)
zzag edited the test plan for this revision. (Show Details)
zzag added a comment.May 30 2018, 7:13 PM

@abetts I recorded the Scale In effect and the Scale Out effect at higher frame rates with the default animation duration(160ms). Could you please check them?

In D13154#271054, @zzag wrote:

@abetts I recorded the Scale In effect and the Scale Out effect at higher frame rates with the default animation duration(160ms). Could you please check them?

I am not sure how. I am running git dev unstable. Would it show if I do an update?

zzag added a comment.May 30 2018, 7:53 PM

I am not sure how. I am running git dev unstable. Would it show if I do an update?

No-no, I am about videos, I re-recorded them. See summary for this diff and D13155. ;-)

In D13154#271077, @zzag wrote:

I am not sure how. I am running git dev unstable. Would it show if I do an update?

No-no, I am about videos, I re-recorded them. See summary for this diff and D13155. ;-)

Looks really good! Good work! +1

ngraham accepted this revision.May 30 2018, 8:18 PM

Looks fantastic to me too. I hope these patches land!

This revision is now accepted and ready to land.May 30 2018, 8:18 PM
zzag abandoned this revision.May 31 2018, 8:37 AM

Why abandon this one? It's improving an existing effect. Surely Martin won't veto it...

zzag added a comment.May 31 2018, 3:40 PM

Why abandon this one? It's improving an existing effect. Surely Martin won't veto it...

Its future is not clear to me (assuming the desire to remove this one), maybe, all this work is for nothing.

Don't give up! We'll find a way to get your work into users' hands. The proposed kwin-extras repo/package might be a good compromise if Martin insists that KWin needs to ship without this effect.

Either way, I strongly encourage you to revive this patch. :) I support it.

abetts added a comment.Jun 1 2018, 3:59 AM

I support this patch

zzag reclaimed this revision.Jun 1 2018, 8:34 AM
This revision is now accepted and ready to land.Jun 1 2018, 8:34 AM
zzag abandoned this revision.Jun 10 2018, 11:09 AM

Superseded by D13461.