Differential D16473

Use runWithPlugin helper in SharePlugin
ClosedPublic
Actions

Authored by nicolasfella on Oct 28 2018, 12:00 AM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:a136d29ff784: Use runWithPlugin helper in SharePlugin
Summary

Depends on D16472

Test Plan

Share file via app
Share file from external app
Share file via direct Share

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
refactorShare
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4255
Build 4273: arc lint + arc unit
nicolasfella created this revision.Oct 28 2018, 12:00 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 28 2018, 12:00 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Oct 28 2018, 12:00 AM
albertvaka accepted this revision.Oct 29 2018, 1:58 PM
albertvaka added a subscriber: albertvaka.
albertvaka added inline comments.
src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java
154

This check got removed. I guess it's intended, but just making sure you are aware of the change.

This revision is now accepted and ready to land.Oct 29 2018, 1:58 PM
Closed by commit R225:a136d29ff784: Use runWithPlugin helper in SharePlugin (authored by nicolasfella). · Explain WhyOct 29 2018, 2:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44336

View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SendFileActivity.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

Loading...