Add runWithPlugin helper
ClosedPublic
Actions

Authored by nicolasfella on Oct 27 2018, 11:16 PM.

Details

Reviewers

albertvaka

Group Reviewers

KDE Connect

Commits

R225:5dc5539e7e07: Add runWithPlugin helper

Summary

There is a common pattern:
BackgroundService.RunCommand

getDevice
check device != null
getPlugin
check plugin != null
doCode

Add a helper for this pattern and port existing code

Repository

R225 KDE Connect - Android application

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Oct 27 2018, 11:16 PM

Nice way to make it generic, ship it!

This revision is now accepted and ready to land.Oct 29 2018, 1:55 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/org/kde/kdeconnect/BackgroundService.java (24 lines)
M			src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java (67 lines)
M			src/org/kde/kdeconnect/Plugins/PresenterPlugin/PresenterActivity.java (24 lines)
M			src/org/kde/kdeconnect/Plugins/SystemvolumePlugin/SystemvolumeFragment.java (18 lines)