z/OS CLIST file syntax highlighting
ClosedPublic
Actions

Authored by phily on Oct 24 2018, 8:27 PM.

Details

Reviewers

dhaumann
cullmann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:185b54827ab0: z/OS CLIST file syntax highlighting

Summary

There was no support for CLIST syntax highlighting so I decided to create this file to add support.

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

phily requested review of this revision.Oct 24 2018, 8:27 PM

Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed.

data/syntax/clist.xml
4	license="MIT" is missing.
4	kateversion="5.0", or are you indeed using an old Kate before Plasma5?
62	Maybe rename Commentar 1 to simply Comment? It seems you copy & pasted the file :)
63	Please use IncludeRules with ##Alerts, look into other highlighting files how this is done.
70	Please remove the hard coded color. Hard coded colors are an issue with different color schemes. See https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ for more default styles.

This revision now requires changes to proceed.Oct 26 2018, 5:49 AM

Fixing issues noted by reviewer

Looking at the code repo I wasn't sure exactly where to include the code examples.

I can add the test for you, otherwise this look ok to go in.

Thanks for the contribution.

The Alert include is missing, but I am not sure if it is really needed ;=)

To properly push it with you as author, what is your full name + mail address?

In D16416#349335, @cullmann wrote:

To properly push it with you as author, what is your full name + mail address?

Phil Young
mainframed767@gmail.com

(I'm assuming you meant email address)

Thanks for the needed info, will merge this.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 1 2018, 4:06 PM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	autotests/folding/test.clist.fold (7 lines)
A	M	autotests/html/test.clist.html (14 lines)
A	M	autotests/input/test.clist (7 lines)
A	M	autotests/reference/test.clist.ref (7 lines)
A	M	data/syntax/clist.xml (87 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44182			Oct 24 2018, 8:26 PM	★	★
Diff 2	44278			Oct 27 2018, 5:18 AM	★	★
Diff 3	44649	a2032c5	R216:185b54827ab03682e4636b378d7f642c5b29dcee	Nov 1 2018, 4:05 PM	★	★