Differential D16410

[Bookmarks Runner] Avoid leaking FetchSqlite instances
ClosedPublic
Actions

Authored by bruns on Oct 24 2018, 6:45 PM.

Details

Reviewers
mart
Group Reviewers
Frameworks
Commits
R120:9e90fdd2a593: [Bookmarks Runner] Avoid leaking FetchSqlite instances
Summary

The favicon and places instances are created in the prepare() call,
leaking the instance from the last invocation. Delete the old
instance in teardown().

See also T9626.

Test Plan

run several queries in krunner
-> instances are no longer leaked

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4168
Build 4186: arc lint + arc unit
bruns created this revision.Oct 24 2018, 6:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2018, 6:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Oct 24 2018, 6:45 PM
mart accepted this revision.Nov 12 2018, 10:47 AM
This revision is now accepted and ready to land.Nov 12 2018, 10:47 AM
Closed by commit R120:9e90fdd2a593: [Bookmarks Runner] Avoid leaking FetchSqlite instances (authored by bruns). · Explain WhyNov 14 2018, 11:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44170

View Options

runners/bookmarks/browsers/firefox.cpp

Loading...