| poboiko | |
| ngraham |
| Baloo | |
| Frameworks |
The KDE4 baloofilerc was only used by dolphin in the KDE4 migration
phase and is no longer needed.
In case a baloofilerc in the legacy location does not exist, the effect
is even worse - the KConfig is instantiated with an empty path, and the
config file name is derived from the application name. This leads to
adding a "[General]" section in e.g. kcmshell5rc or systemsettingsrc.
Also see T9897.
modify config using balooctl config {add,rm} or using SystemSettings
-> .config/baloorc resp. .config/systemsettingsrc is no longer written,
only .config/baloofilerc.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Looks good, but what's our transition plan? Does this need any special handling for people who already have old config files?
Currently, there is some garbage left in a few config files (potentially any application which writes some baloo config keys), on my system:
balooctl: ~/.config/baloorc
systemsettings/search: ~/.config/kcmshell5rc, ~/.config/systemsettingsrc
I am not aware of any bad side effects having these garbage entries. baloo itself (or any of its library functions) newer read these keys from
the mentioned files, only from ~/.config/baloofilerc.
Adding cleanup code is of course possible, but this code:
As this change is an improvement even without the cleanup, I would postpone the cleanup.