Resolve symlinks before saving so we don't "break" them
ClosedPublic

Authored by aacid on Oct 21 2018, 9:10 PM.

Diff Detail

Repository
R223 Okular
Branch
arcpatch-D16364
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4118
Build 4136: arc lint + arc unit
aacid created this revision.Oct 21 2018, 9:10 PM
Restricted Application added a project: Okular. · View Herald TranscriptOct 21 2018, 9:10 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
aacid requested review of this revision.Oct 21 2018, 9:10 PM
ngraham requested changes to this revision.Oct 21 2018, 10:18 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! However this does not actually work for me. See the following video (taken with the patch applied):

I think realSaveUrl.toLocalFile() needs to be saveUrl.toLocalFile(). Then it works.

part.cpp
2540

Shouldn't realSaveUrl.toLocalFile() be saveUrl.toLocalFile()?

This revision now requires changes to proceed.Oct 21 2018, 10:18 PM
aacid added inline comments.Oct 21 2018, 10:27 PM
part.cpp
2540

Yeah, that's what you get when you rewrite the match at last minute and don't test it again.

aacid updated this revision to Diff 44050.Oct 21 2018, 10:29 PM

fix code

ngraham accepted this revision.Oct 22 2018, 3:46 AM

Much better, thanks. Works now and fixes the bug.

Let's get this into 18.12.3!

This revision is now accepted and ready to land.Oct 22 2018, 3:46 AM

Please remove 'S' from BUGS in the summary.

Please remove 'S' from BUGS in the summary.

No, BUGS works just fine.

https://cgit.kde.org/repo-management.git/tree/hooks/hooklib.py#n752

aacid closed this revision.Oct 22 2018, 7:41 PM