Differential D16357

Use new syntax for connections and get rid of deprecated KIO::Job::canceled
ClosedPublic
Actions

Authored by yurchor on Oct 21 2018, 5:30 PM.

Details

Reviewers
broulik
aacid
Group Reviewers
KDE Applications
Commits
R228:1db0e12b2b3b: Use new syntax for connections and get rid of deprecated KIO::Job::canceled
Summary

It seems that the new style is preferred now.

After the connection conversion, gcc compiler warns about KIO::Job::canceled deprecation. API docs say that it can be safely replaced with result() "and error() is, in this case, ERR_USER_CANCELED." So we do.

https://api.kde.org/frameworks/kio/html/classKIO_1_1Job.html#a16f78937ceba1bf95ca9852ddbd5c5b5

Test Plan
  1. Start KFind, configure search parameters.
  2. Start the search process then stop it when something is found. All should work flawlessly.

Diff Detail

Repository
R228 KFind
Lint
Lint Skipped
Unit
Unit Tests Skipped
yurchor requested review of this revision.Oct 21 2018, 5:30 PM
yurchor created this revision.
aacid accepted this revision.Oct 21 2018, 7:23 PM
aacid added a subscriber: aacid.

Not having context makes things a bit harder to review, personally i would really appreciate it if you could try to get arc installed.

This revision is now accepted and ready to land.Oct 21 2018, 7:23 PM
Closed by commit R228:1db0e12b2b3b: Use new syntax for connections and get rid of deprecated KIO::Job::canceled (authored by yurchor). · Explain WhyOct 22 2018, 5:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kfinddlg.cpp (8 lines)
Msrc/kquery.h (1 line)
Msrc/kquery.cpp (23 lines)

Diff 44034

View Options

src/kfinddlg.cpp

Loading...
View Options

src/kquery.h

Loading...
View Options

src/kquery.cpp

Loading...