Differential D16272

apply eexist workaround from listDir to stat as well
ClosedPublic
Actions

Authored by sitter on Oct 17 2018, 2:17 PM.

Details

Reviewers
broulik
Commits
R320:cf34ba609dc4: apply eexist workaround from listDir to stat as well
R320:76402b7c61da: apply eexist workaround from listDir to stat as well
Summary

knetattach stats() without first doing a listDir() so in the event that
the url requires authentication it won't work and error out on the EEXISTS.
listDir has a fallback hack for this which was missing from stat.

stat now has this workaround as well and correctly brings up an auth
dialog on shares that require it.

BUG: 399699

Test Plan
  • knetattach
  • smb
  • data for host (folder should require auth)
  • save and connect
  • auth dialog comes up
  • enter details
  • ok
  • works

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Oct 17 2018, 2:17 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptOct 17 2018, 2:17 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Oct 17 2018, 2:17 PM
sitter edited the test plan for this revision. (Show Details)Oct 17 2018, 2:18 PM
sitter added a reviewer: broulik.
broulik accepted this revision.Oct 17 2018, 2:28 PM
This revision is now accepted and ready to land.Oct 17 2018, 2:28 PM
Closed by commit R320:cf34ba609dc4: apply eexist workaround from listDir to stat as well (authored by sitter). · Explain WhyOct 17 2018, 2:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (2 lines)

Diff 43795

View Options

smb/kio_smb_browse.cpp

Loading...