| mlaurent | |
| dvratil |
Otherwise once the dialog is closed you can't get back to what
notifications are pending (suspended) until a notification is shown.
Removed passing mCalendar to createReminder, which already had access to the member variable and no longer even uses it.
Go to the dock window menu, click on "Show Reminders", verify the Reminders dialog comes up.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Thanks for the patch! Just a minor nitpick, otherwise it looks good.
| korgac/koalarmclient.cpp | ||
|---|---|---|
| 259 | This is just a nitpick, but would you mind renaming this to createDialog() (it's more common terminology in our code than allocate). | |
Thanks.
This has to go to master because of the string change, so it will be available in 18.12. We'll push this for you if you don't have commit access.