dfries (David Fries)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2018, 1:39 PM (287 w, 1 d)
Availability
Available

Recent Activity

Oct 25 2018

dfries added a comment to D16245: korgac: Save size and position on dialog hide/close and improve restore.

I'm seeing D16242, D16243, D16244, and this one D16245 are ready to land, can one of you two land these for me?

Oct 25 2018, 5:38 PM · KDE PIM

Oct 22 2018

dfries updated the diff for D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.

grabFocus, tooltip message you posted

Oct 22 2018, 1:40 AM · KDE PIM

Oct 20 2018

dfries added inline comments to D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.
Oct 20 2018, 1:03 PM · KDE PIM
dfries updated the diff for D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.

const bool grabfocus
different menu label, added tooltip, enabled tooltips
used newer connect style
removed qCDebug, config.sync();

Oct 20 2018, 1:01 PM · KDE PIM
dfries updated the diff for D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.
Oct 20 2018, 2:17 AM · KDE PIM

Oct 18 2018

dfries added a comment to D16240: korgac: remove m prefix for local variable topLayout.

Laurent, please okay the review and land D16240

Oct 18 2018, 4:32 AM · KDE PIM
dfries added a dependent revision for D16246: korgac: For no grab avoid mouse cursor when placing window: D16247: korgac: Call setOnAllDesktops from showEvent.
Oct 18 2018, 4:27 AM · KDE PIM
dfries added a dependency for D16247: korgac: Call setOnAllDesktops from showEvent: D16246: korgac: For no grab avoid mouse cursor when placing window.
Oct 18 2018, 4:27 AM · KDE PIM
dfries added a dependency for D16246: korgac: For no grab avoid mouse cursor when placing window: D16245: korgac: Save size and position on dialog hide/close and improve restore.
Oct 18 2018, 4:26 AM · KDE PIM
dfries added a dependent revision for D16245: korgac: Save size and position on dialog hide/close and improve restore: D16246: korgac: For no grab avoid mouse cursor when placing window.
Oct 18 2018, 4:26 AM · KDE PIM
dfries added a dependent revision for D16244: korgac: Make the korgac notification dialog even smaller: D16245: korgac: Save size and position on dialog hide/close and improve restore.
Oct 18 2018, 4:26 AM · KDE PIM
dfries added a dependency for D16245: korgac: Save size and position on dialog hide/close and improve restore: D16244: korgac: Make the korgac notification dialog even smaller.
Oct 18 2018, 4:26 AM · KDE PIM
dfries added a dependent revision for D16240: korgac: remove m prefix for local variable topLayout: D16244: korgac: Make the korgac notification dialog even smaller.
Oct 18 2018, 4:25 AM · KDE PIM
dfries added a dependency for D16244: korgac: Make the korgac notification dialog even smaller: D16240: korgac: remove m prefix for local variable topLayout.
Oct 18 2018, 4:25 AM · KDE PIM
dfries added a dependent revision for D16240: korgac: remove m prefix for local variable topLayout: D16243: korgac: Add a menu option to always get to the reminder dialog..
Oct 18 2018, 4:23 AM · KDE PIM
dfries added dependencies for D16243: korgac: Add a menu option to always get to the reminder dialog.: D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed, D16240: korgac: remove m prefix for local variable topLayout.
Oct 18 2018, 4:23 AM · KDE PIM
dfries added a dependent revision for D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed: D16243: korgac: Add a menu option to always get to the reminder dialog..
Oct 18 2018, 4:23 AM · KDE PIM
dfries updated the diff for D16246: korgac: For no grab avoid mouse cursor when placing window.

added const, edited if, for { style

Oct 18 2018, 3:59 AM · KDE PIM
dfries updated the diff for D16245: korgac: Save size and position on dialog hide/close and improve restore.

added const, if<space>(

Oct 18 2018, 3:57 AM · KDE PIM

Oct 17 2018

dfries added a comment to D16246: korgac: For no grab avoid mouse cursor when placing window.

One other bug unrelated to this patch sequence and I wouldn't think it would be specific to korgac. If I don't set the theme it doesn't get stuck printing the message, but it doesn't have the theme. I didn't know if you would have any suggestions off the top of your head, other than start debugging.

Oct 17 2018, 2:36 PM · KDE PIM
dfries added a comment to D16246: korgac: For no grab avoid mouse cursor when placing window.

KWindowSystem::setUserTime(winId(), 0);
"The most common case is the special value 0 which means not to activate the window after being shown." Whatever that means, because I called it before QDialog::show(); (the documentation doesn't say and I'm assuming if you've already called show() it's too late), and didn't see a getting focus behavior difference in fvwm or kde (tested without this patch, so the Reminder window appeared where it was last).

// KDE with "Focus Follows Mouse - Mouse Precedence"
// called with 0, mouse not under window, gets focus
// not called, mouse not under window, gets focus
// KDE with "Click to Focus"
// called with 0, mouse not under window, doesn't get focus
// not called, mouse not under window, doesn't get focus
// called with 0, mouse under window, gets focus
// not called, mouse under window, gets focus
Oct 17 2018, 2:12 PM · KDE PIM
dfries updated the diff for D16245: korgac: Save size and position on dialog hide/close and improve restore.

Moved the resize() argument up to be the rectangle default size if the configuration file doesn't have one, in addition to the requested changes.

Oct 17 2018, 4:17 AM · KDE PIM
dfries added a comment to D16245: korgac: Save size and position on dialog hide/close and improve restore.

redoing patch

Oct 17 2018, 4:15 AM · KDE PIM
dfries updated the diff for D16244: korgac: Make the korgac notification dialog even smaller.

updated with the two requested changes, setMinimumSize, remove setStyleSheet

Oct 17 2018, 3:51 AM · KDE PIM
dfries added a comment to D16244: korgac: Make the korgac notification dialog even smaller.

will update the patch...

Oct 17 2018, 3:50 AM · KDE PIM

Oct 16 2018

dfries added a comment to D16244: korgac: Make the korgac notification dialog even smaller.

inline comment

Oct 16 2018, 1:54 PM · KDE PIM
dfries added a comment to D16243: korgac: Add a menu option to always get to the reminder dialog..

marked inline comment as done, this feature was very useful in development

Oct 16 2018, 1:30 PM · KDE PIM
dfries updated the diff for D16243: korgac: Add a menu option to always get to the reminder dialog..

renamed allocateDialog to createDialog

Oct 16 2018, 1:26 PM · KDE PIM
dfries added a comment to D16240: korgac: remove m prefix for local variable topLayout.

Montel, you asked to change the summary, how about removing it? It's pretty trivial and there's probably nothing more to say than the subject, or do you have something else in mind.
Who does the next step, because as far as I know I don't have permissions to apply the change.

Oct 16 2018, 1:15 PM · KDE PIM
dfries updated the summary of D16240: korgac: remove m prefix for local variable topLayout.
Oct 16 2018, 1:12 PM · KDE PIM
dfries requested review of D16247: korgac: Call setOnAllDesktops from showEvent.
Oct 16 2018, 4:24 AM · KDE PIM
dfries requested review of D16246: korgac: For no grab avoid mouse cursor when placing window.
Oct 16 2018, 4:18 AM · KDE PIM
dfries updated the summary of D16245: korgac: Save size and position on dialog hide/close and improve restore.
Oct 16 2018, 4:11 AM · KDE PIM
dfries requested review of D16245: korgac: Save size and position on dialog hide/close and improve restore.
Oct 16 2018, 4:10 AM · KDE PIM
dfries requested review of D16244: korgac: Make the korgac notification dialog even smaller.
Oct 16 2018, 3:50 AM · KDE PIM
dfries requested review of D16243: korgac: Add a menu option to always get to the reminder dialog..
Oct 16 2018, 3:38 AM · KDE PIM
dfries requested review of D16242: korgac: Add an option to not grab keyboard focus when a reminder is displayed.
Oct 16 2018, 3:32 AM · KDE PIM
dfries requested review of D16240: korgac: remove m prefix for local variable topLayout.
Oct 16 2018, 3:06 AM · KDE PIM