Differential D16240

korgac: remove m prefix for local variable topLayout
ClosedPublic
Actions

Authored by dfries on Oct 16 2018, 3:06 AM.

Details

Reviewers
mlaurent
Commits
R210:15eb0e9f06c9: korgac: remove m prefix for local variable topLayout
Test Plan

variable rename, just compile

Diff Detail

Repository
R210 KOrganizer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfries created this revision.Oct 16 2018, 3:06 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 16 2018, 3:06 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfries requested review of this revision.Oct 16 2018, 3:06 AM
mlaurent requested changes to this revision.Oct 16 2018, 4:53 AM

Change the sumary but after that it ok.
Thanks

This revision now requires changes to proceed.Oct 16 2018, 4:53 AM
dfries edited the summary of this revision. (Show Details)Oct 16 2018, 1:12 PM
dfries added a comment.Oct 16 2018, 1:15 PM

Montel, you asked to change the summary, how about removing it? It's pretty trivial and there's probably nothing more to say than the subject, or do you have something else in mind.
Who does the next step, because as far as I know I don't have permissions to apply the change.

mlaurent added a comment.Oct 16 2018, 1:26 PM

For committing I can do it for you if you want.

dfries added a comment.Oct 18 2018, 4:32 AM

Laurent, please okay the review and land D16240

D16242 D16244 D16245 D16246 are ready for review
It will be best to land in numerical order.

mlaurent accepted this revision.Oct 18 2018, 5:16 AM
This revision is now accepted and ready to land.Oct 18 2018, 5:16 AM
Closed by commit R210:15eb0e9f06c9: korgac: remove m prefix for local variable topLayout (authored by mlaurent). · Explain WhyOct 18 2018, 5:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkorgac/alarmdialog.cpp (12 lines)

Diff 43838

View Options

korgac/alarmdialog.cpp

Loading...