Port KmPlot away from deprecated KIO::NetAccess and KImageIO
ClosedPublic
Actions

Authored by yurchor on Oct 10 2018, 8:46 PM.

Details

Reviewers

cfeck

Group Reviewers

KDE Edu

Commits

Summary

Most of the code is borrowed from this revision for KMyMoney:

Test Plan

Save a plot to a network resource. Everything should work.
Load a plot from a network resource. Everything should work.
The same things should work for the plot parameters (Parameters -> Edit list... ->Import/Export)
Export a plot to a bitmap or SVG (File -> Export) on a local disk or network resource. Everything should work.

Repository

R334 KmPlot

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

yurchor requested review of this revision.Oct 10 2018, 8:46 PM

Awesome. So it does (also) fix bug 360685?

kmplot/maindlg.cpp
621	indentation

In D16117#341046, @cfeck wrote:

Awesome. So it does (also) fix bug 360685?

Cannot (actually, have no time) test what was earlier but with the following commit it works as well (tested):

BUG: 360685

Fix indentation.

This revision is now accepted and ready to land.Oct 11 2018, 8:20 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kmplot/kmplotio.cpp (37 lines)
M			kmplot/kparametereditor.cpp (104 lines)
M			kmplot/maindlg.h (5 lines)
M			kmplot/maindlg.cpp (51 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43349			Oct 10 2018, 8:36 PM	★	★
Diff 2	43369			Oct 11 2018, 5:11 AM	★	★
Diff 3	43381	506f56d	R334:5ec2e1db6abbc985ece26bd5aef94a8776f33258	Oct 11 2018, 10:09 AM	★	★