[libkwineffects] Drop AniData constructor that receives QString
ClosedPublic
Actions

Authored by zzag on Oct 10 2018, 9:40 AM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

Summary

This code has several bugs, it's untested, it's not used anywhere, it
adds unnecessary complexity -> delete it.

Test Plan

Compiles.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptOct 10 2018, 9:40 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Oct 10 2018, 9:40 AM

This revision is now accepted and ready to land.Oct 10 2018, 9:41 AM

This revision was automatically updated to reflect the committed changes.

Please increase the so version of the library as that was an ABI incompatible change.

Already happened for 5.15

			Path	Packages
M			libkwineffects/anidata.cpp (113 lines)
M			libkwineffects/anidata_p.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43274	48002ab		Oct 10 2018, 9:40 AM	★	★
Diff 2	43283	48002ab	R108:2569768074f9bc7dbd7cb38aa37c2ceb8c41a1f4	Oct 10 2018, 9:57 AM	★	★