Differential D16099

[libkwineffects] Drop AniData constructor that receives QString
ClosedPublic
Actions

Authored by zzag on Oct 10 2018, 9:40 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:2569768074f9: [libkwineffects] Drop AniData constructor that receives QString
Summary

This code has several bugs, it's untested, it's not used anywhere, it
adds unnecessary complexity -> delete it.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Branch
libkwineffects-drop-qstring-anidata-constructor
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3713
Build 3731: arc lint + arc unit
zzag created this revision.Oct 10 2018, 9:40 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 10 2018, 9:40 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 10 2018, 9:40 AM
davidedmundson accepted this revision.Oct 10 2018, 9:41 AM
This revision is now accepted and ready to land.Oct 10 2018, 9:41 AM
Closed by commit R108:2569768074f9: [libkwineffects] Drop AniData constructor that receives QString (authored by zzag). · Explain WhyOct 10 2018, 9:57 AM
This revision was automatically updated to reflect the committed changes.
graesslin added a subscriber: graesslin.Oct 10 2018, 3:02 PM

Please increase the so version of the library as that was an ABI incompatible change.

davidedmundson added a comment.Oct 10 2018, 3:02 PM

Already happened for 5.15

Revision Contents
Changeset List

PathPackages
Mlibkwineffects/anidata.cpp (113 lines)
Mlibkwineffects/anidata_p.h (3 lines)

Diff 43274

View Options

libkwineffects/anidata.cpp

Loading...
View Options

libkwineffects/anidata_p.h

Loading...