Scrolling horizontally for a small bit of the page feels awkward.
BUG: 373957
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Branch
- resize_config_window (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3644 Build 3662: arc lint + arc unit
Comment Actions
629 is a random number, random numbers are bad.
What about people using other styles? other fonts?
Comment Actions
@aacid is correct. If the size is not being set correctly, we should look at the dialog's sizeHint rather than overriding it entirely.
Comment Actions
You are right, of course. Magic constants are bad.
I could not, however, find a way to obtain the side bar width in order to calculate the correct sizeHint of the dialogue.
The only way I could get it to work is by modifying the KConfigDialog::KConfigDialogPrivate::addPageInternal() function in the KConfigWidgets library.
Would such a change even be considered to solve this minor issue?
In Dolphin, the solution also seems to have been a magic constant (see the relevant line in dolphinsettingsdialog.cpp).
Comment Actions
If you can fix this correctly once in KConfigDialog instead of adding bad magic numbers everywhere, fixing it in KConfigDialog seems to be a no brainer (maybe with an flag option to not change behaviour for people that don't want that)
Comment Actions
Similar incorrect solution as the one suggested in D21910.
Might be worth some time investigating why the window gets the wrong sizeHint.