Differential D16041

Correction for Merge Multiple Layers with Alpha Inheritance
AbandonedPublic
Actions

Authored by eoinoneill on Oct 8 2018, 9:48 AM.

Details

Reviewers
dkazakov
rempt
Group Reviewers
Krita
Summary

Correction for Bug:399146 , which created an issue where alpha inheritance on non-active layer did not trigger recompositing. I believe that the problem was caused by a missing binary not, since the code comment above seems to imply that compositing isn't necessary when flags DON'T vary, not the other way around.

Note: Shouldn't recompositing also occur in conditions where the selected layers are not linearly arranged?

Test Plan

Try merging layers with different configurations, especially in file provided by bug reporter.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
eoinoneill created this revision.Oct 8 2018, 9:48 AM
Restricted Application added a reviewer: Krita. · View Herald TranscriptOct 8 2018, 9:48 AM
eoinoneill requested review of this revision.Oct 8 2018, 9:48 AM
eoinoneill edited the test plan for this revision. (Show Details)
eoinoneill retitled this revision from Correction to Merge Multiple Layers with Alpha Inheritance to Correction for Merge Multiple Layers with Alpha Inheritance.Oct 8 2018, 9:52 AM
rempt added a comment.Oct 8 2018, 12:15 PM

Yes, I think this is correct... I'm not 100% sure, though!

dkazakov requested changes to this revision.Oct 8 2018, 4:51 PM

Hi, @eoinoneill!

The patch resurrects the original this condition fixes: pressing Ctrl+E on a Group Layer with Inherit Alpha option now makes it fully transparent :(

This revision now requires changes to proceed.Oct 8 2018, 4:51 PM
eoinoneill abandoned this revision.Oct 9 2018, 7:48 AM

This has been resolved.

Revision Contents
Changeset List

PathPackages
Mlibs/image/kis_layer_utils.cpp (2 lines)

Diff 43116

View Options

libs/image/kis_layer_utils.cpp

Loading...