Differential D1602

Port Wintab screen size dialog
ClosedPublic
Actions

Authored by abrahams on May 13 2016, 3:45 AM.

Details

Reviewers
None
Group Reviewers
Krita
Maniphest Tasks
T2393: Some weird stuff with tablet configuration dialog
Commits
R37:c7621d2d80c8: Port Wintab screen size dialog
Summary

Unfortunately the existing screen handling doesn't do a good enough job.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 3795.May 13 2016, 3:45 AM
abrahams retitled this revision from to Port Wintab screen size dialog.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: Krita.
abrahams added a task: T2393: Some weird stuff with tablet configuration dialog.
abrahams mentioned this in T2393: Some weird stuff with tablet configuration dialog.May 13 2016, 3:49 AM

The Qt and Wintab resolutions always match on my machines, which I suppose is a good thing.

rempt added a subscriber: rempt.May 13 2016, 5:20 AM

The weird thing is, I never have problems either. Not with screen mapping; if I connect my SP3 to a monitor, then disconnect, Qt is all confused about font sizes, but never about the tablet mapping. Cintiq + normal monitor also never gives trouble in Windows or Linux. I don't know what people are doing, but it's clear that there's a lot of variation in settings out there so I'm wondering whether we shouldn't put this screen in the settings dialog instead.

abrahams added a comment.May 26 2016, 8:21 AM

Can I land this right now and replace it in the settings window some other time?

rempt added a comment.May 26 2016, 8:24 AM

Yes, that might be best.

Closed by commit R37:c7621d2d80c8: Port Wintab screen size dialog (authored by abrahams). · Explain WhyMay 26 2016, 8:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4009

View Options

libs/ui/input/wintab/kis_tablet_support_win.cpp

Loading...