Differential D16017

Don't show phonenumber if name is available
ClosedPublic
Actions

Authored by nicolasfella on Oct 7 2018, 2:57 PM.

Details

Reviewers
sredman
Group Reviewers
KDE Connect
Commits
R224:8bfe093939a2: Don't show phonenumber if name is available
Summary

Showing the number next to the name is neither pretty nor necessary IMHO.

My Android SMS app displays the number more subtle in an extra line below in gray. I could get behind something similar, but until this is implemented just don't show it

Depends on D16015

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Oct 7 2018, 2:57 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 7 2018, 2:57 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Oct 7 2018, 2:57 PM
sredman accepted this revision.Oct 8 2018, 3:56 AM
sredman added a subscriber: sredman.

Seems fair. I agree that showing the phone number might be a nice future step, but my Android-side SMS app doesn't show anything and I only rarely care

This revision is now accepted and ready to land.Oct 8 2018, 3:56 AM
Closed by commit R224:8bfe093939a2: Don't show phonenumber if name is available (authored by nicolasfella). · Explain WhyOct 8 2018, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmsapp/qml/ConversationDisplay.qml (2 lines)

Diff 43153

View Options

smsapp/qml/ConversationDisplay.qml

Loading...