Fix person name displaying in ConversationDisplay
ClosedPublic
Actions

Authored by nicolasfella on Oct 7 2018, 2:47 PM.

Details

Reviewers

sredman

Group Reviewers

KDE Connect

Commits

Summary

Don't ask my why this works this way

Test Plan

I see Name: phonenumber for contacts and just phonenumber for non-contacts now

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Oct 7 2018, 2:47 PM

Thanks for this! I remember looking at this problem but who would have guessed that person had a nested person? :)

This revision is now accepted and ready to land.Oct 8 2018, 3:51 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			smsapp/qml/ConversationDisplay.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43044	a48e29b		Oct 7 2018, 2:47 PM	★	★
Diff 2	43152	3a57d45	R224:45e966c290d658ef96a18c88137a874b66cf192d	Oct 8 2018, 6:36 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
797f4a138df8	afd037e7544b	a48e29b166a9	Nicolas Fella	Fix person name displaying in ConversationDisplay (Show More…)	Oct 7 2018, 2:44 PM

	Status	Author	Revision
	Closed	nicolasfella	D16017 Don't show phonenumber if name is available
	Closed	nicolasfella	D16015 Fix person name displaying in ConversationDisplay