Differential D15993

[PositionCodec] Avoid crash in case of corrupt data
ClosedPublic
Actions

Authored by bruns on Oct 6 2018, 11:35 PM.

Details

Reviewers
poboiko
ngraham
Group Reviewers
Frameworks
Baloo
Commits
R293:2d31a8500edb: [PositionCodec] Avoid crash in case of corrupt data
Summary

getDifferentialVarInt* returns a nullptr in case of a decoding error.

See also D11825.

BUG: 367480

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 6 2018, 11:35 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 6 2018, 11:35 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 6 2018, 11:35 PM
ngraham accepted this revision.Oct 6 2018, 11:45 PM

Thanks! Any chance this will fix https://bugs.kde.org/show_bug.cgi?id=367480?

This revision is now accepted and ready to land.Oct 6 2018, 11:45 PM
bruns edited the summary of this revision. (Show Details)Oct 6 2018, 11:54 PM
In D15993#337854, @ngraham wrote:

Thanks! Any chance this will fix https://bugs.kde.org/show_bug.cgi?id=367480?

Absolutely!

ngraham added a comment.Oct 6 2018, 11:55 PM

Congrats, you just fixed the most common Baloo crash. :)

Closed by commit R293:2d31a8500edb: [PositionCodec] Avoid crash in case of corrupt data (authored by bruns). · Explain WhyOct 6 2018, 11:58 PM
This revision was automatically updated to reflect the committed changes.
bruns added a comment.Oct 7 2018, 12:18 AM
In D15993#337880, @ngraham wrote:

Congrats, you just fixed the most common Baloo crash. :)

Thx - I am just selfish here ;-)

Revision Contents
Changeset List

PathPackages
Msrc/codecs/positioncodec.cpp (3 lines)

Diff 42995

View Options

src/codecs/positioncodec.cpp

Loading...