Making the code editor widget tabs closable by creating a
method that receives a signal from the tabCloseRequest, closing the
specified tab and removing it's code document properly.
Details
Details
Diff Detail
Diff Detail
- Repository
- R73 Rocs
- Branch
- makingEditorTabsClosable
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3556 Build 3574: arc lint + arc unit
src/ui/codeeditorwidget.cpp | ||
---|---|---|
44 ↗ | (On Diff #42986) | Unrelated |
Comment Actions
Closing the source file directly leads to deleting the whole code document. IMO that is a too big operation to connect to the small [X] icon, which one could accidentally press, even when switching documents.
Either there should be a confirmation dialog that the source code really shall be deleted. Or there should be a code file deletion option that is only provided in a menu to avoid accidental code deletion.
src/project/project.cpp | ||
---|---|---|
256 ↗ | (On Diff #43135) | code style, return in the next line. |
src/ui/codeeditorwidget.cpp | ||
27 ↗ | (On Diff #42986) | stray include. |
111 ↗ | (On Diff #42986) | While this removeCodeDocument will not remove if the KTextDocument says that it will not close, this is not obvious. |
Comment Actions
Removing stray include, renaming method and fixing line according to correct code style.