Differential D15984

Close unneeded FDs before startup
AbandonedPublic
Actions

Authored by fvogt on Oct 6 2018, 4:43 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Summary

This works around a firefox bug which causes sockets to internet addresses to
get inherited by native host processes. Those are listed as outgoing
connections opened by plasma-browser-integration-host in netstat/ss.

CCBUG: 399449

Test Plan

Checked with ss -ap | grep plasma and also
ll /proc/$(pidof plasma-browser-integration-host)/fd/ after starting firefox.
No inherited sockets anymore.

Diff Detail

Repository
R856 Plasma Browser Integration
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3546
Build 3564: arc lint + arc unit
fvogt created this revision.Oct 6 2018, 4:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 6 2018, 4:43 PM
fvogt requested review of this revision.Oct 6 2018, 4:43 PM
fvogt edited the test plan for this revision. (Show Details)Oct 6 2018, 4:44 PM
davidedmundson added a subscriber: davidedmundson.Oct 8 2018, 10:39 AM

The bug reporter said a version of the patch causes busy loops? Is that this one?

fvogt abandoned this revision.Oct 8 2018, 10:56 AM
In D15984#339062, @davidedmundson wrote:

The bug reporter said a version of the patch causes busy loops? Is that this one?

Yes. I'll abandon it anyway as this bug is too low prio to add such a hack.

Revision Contents
Changeset List

PathPackages
Mhost/main.cpp (14 lines)

Diff 42973

View Options

host/main.cpp

Loading...