Correct braces and add contributors
ClosedPublic

Authored by sredman on Oct 5 2018, 11:30 PM.

Details

Summary

Braces to start a method are on a newline, braces to begin an in-method block are on the same line

Test Plan

Pure source code cosmetic changes. Hopefully no functionality has changed!

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sredman created this revision.Oct 5 2018, 11:30 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 5 2018, 11:30 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Oct 5 2018, 11:30 PM
sredman added inline comments.
smsapp/main.cpp
6–18

As long as I'm touching these files, should we change the license to GPLv2+ like the rest of the project?

41

@nicolasfella Let me know if you don't want this here (or if you think you should be in more places!)

nicolasfella accepted this revision.Oct 6 2018, 2:21 PM
nicolasfella added a subscriber: apol.
nicolasfella added inline comments.
smsapp/main.cpp
6–18

I would say that makes sense. I see that more files in the smsapp are also affected by this. I'm not a licensing expert, but I think formally you would need approval from all contributors to the smsapp for this. You hereby have mine, but to be sure you should ask @apol for his.

41

Fine with me :)

This revision is now accepted and ready to land.Oct 6 2018, 2:21 PM
This revision was automatically updated to reflect the committed changes.