Braces to start a method are on a newline, braces to begin an in-method block are on the same line
Details
Details
- Reviewers
nicolasfella - Group Reviewers
KDE Connect - Commits
- R224:563dde989163: Correct braces and add contributors
Pure source code cosmetic changes. Hopefully no functionality has changed!
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- code-style
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 3534 Build 3552: arc lint + arc unit
| smsapp/main.cpp | ||
|---|---|---|
| 6–18 | As long as I'm touching these files, should we change the license to GPLv2+ like the rest of the project? | |
| 41 | @nicolasfella Let me know if you don't want this here (or if you think you should be in more places!) | |
| smsapp/main.cpp | ||
|---|---|---|
| 6–18 | I would say that makes sense. I see that more files in the smsapp are also affected by this. I'm not a licensing expert, but I think formally you would need approval from all contributors to the smsapp for this. You hereby have mine, but to be sure you should ask @apol for his. | |
| 41 | Fine with me :) | |