| ngraham |
| Frameworks | |
| Baloo |
Right now balooctl monitor connects only to the fileindexer DBus interface, and monitors only for files indexing.
This patch makes monitor to connect also to the scheduler interface to stateChanged(int state) signal, and notify about updates.
FIXED-IN: 5.52
| No Linters Available |
| No Unit Test Coverage |
| Buildable 3487 | |
| Build 3505: arc lint + arc unit |
Looks sane in general. Can you extend the summary a bit, e.g. "Connect to the scheduler DBus interface to ...."? Thx
Works for me and the code looks sane. Looks like this fixes https://bugs.kde.org/show_bug.cgi?id=364858, so can you add BUG: 364858 and FIXED-IN: 5.52 to the summary section and also make the changes that @bruns requested? Thanks!
Also, please don't commit this until after Frameworks 5.51 has been tagged (which is tomorrow). This is the kind of change that we should have a month to test out ourselves before releasing it to customers.
Weird, bug 364858 should be fine as it is - user asks for a way to display files Baloo is currently processing, but that's exactly what monitor does (even without this patch).
Also, please don't commit this until after Frameworks 5.51 has been tagged (which is tomorrow). This is the kind of change that we should have a month to test out ourselves before releasing it to customers.
Sure, totally agree!
I think 364858 is not affected by this, but is still broken.
The monitor command watches for changes of the filename, but misses to fetch currentFile on startup. When the indexer "hangs", we never get a signal.