How can I test this? Or even, how did you test this?

For Bluetooth we currently use:

• disabled: grayed out/softened icon
• active: black icon
• paired: black icon with dots next to each other

That "padlock" doesn't communicate "paired" to me and is inconsistent with Plasma's icon

In D15934#336261, @ngraham wrote:

How can I test this? Or even, how did you test this?

I tested it by comparing the icons and names with Adwaita and Papirus, then asking an Xfce user to see if the icons worked for them on their laptop. This was a week or two ago and they didn't report any problems since I gave them the icons.

Do note that I did not include Xfce specific symlinks for bluetooth status icons (blueman and blueberry symlinks) in this commit. I want to find out if they are really necessary for Xfce. If they are, I will include them later in a general Xfce compatibility patch. In the mean time, the bluetooth icons should be compatible with most DEs without needing additional symlinks since they use the same names as Adwaita.

In D15934#336349, @broulik wrote:

For Bluetooth we currently use:

• disabled: grayed out/softened icon
• active: black icon
• paired: black icon with dots next to each other That "padlock" doesn't communicate "paired" to me and is inconsistent with Plasma's icon

Actually, the icon with dots on both sides is used when a device is connected in other DEs, so I'm not sure if the icon with the padlock is used much at all. Adwaita doesn't include it. I'm just including it because Papirus does.

This is Xfce:
https://cdn.discordapp.com/attachments/366985425371398148/497318487736188929/Screenshot_2018-10-04_16-05-47.png

It is actual part of the Breeze Plasma theme though:

And it does match the icon Papirus uses for bluetooth-paired:

It is actual part of the Breeze Plasma theme though:

Interesting. I have never seen it used, though. Then the Bluetooth applet (and likely Network manager applet) need to be fixed to use that one instead. Not sure I would like the padlock when my headphones are connected.

In D15934#336409, @broulik wrote:

It is actual part of the Breeze Plasma theme though:

Interesting. I have never seen it used, though. Then the Bluetooth applet (and likely Network manager applet) need to be fixed to use that one instead. Not sure I would like the padlock when my headphones are connected.

To be honest, I don't think that's really necessary. If other DEs don't use that icon and we don't need that icon, why not just remove it or ignore it? Grey/50% opacity for disabled, normal for enabled and the dots on either side for active connection should be enough.

@ngraham @broulik Do you have any objections or questions about this commit?

I have no objection to the concept, but I like to test patches before I approve them, and I'm still not sure how I would satisfactorily test this without taking up an afternoon setting up a dev environment in an XFCE-using distro in a VM, which unfortunately is time I just don't have at the moment.

In D15934#339276, @ngraham wrote:

I have no objection to the concept, but I like to test patches before I approve them, and I'm still not sure how I would satisfactorily test this without taking up an afternoon setting up a dev environment in an XFCE-using distro in a VM, which unfortunately is time I just don't have at the moment.

Fair enough. If I did it and took a series of screenshots, would that be good enough for you?

Yeah, I'd be happy about that!